Adds shutdown hook #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
============================================
+ Coverage 72.29% 72.81% +0.51%
- Complexity 113 116 +3
============================================
Files 20 20
Lines 509 515 +6
Branches 38 38
============================================
+ Hits 368 375 +7
Misses 118 118
+ Partials 23 22 -1
Continue to review full report at Codecov.
|
|
@robertotru, any feedback on this pr? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had problems running redis-embedded with spring boot in a jenkins pipeline.
Sometimes the redis stop is not efficient leaving the port stuck in the pipeline as a result of which the next job fails.
I added a hook for when the process that started the redis-embedded stops then it forces the redis to stop.
I was unable to create an automated test for this, if anyone has any suggestions I would appreciate it.
when run together with spring it stops the redis in the sequence that spring-context stops.